streamclient: remove the dial method #138092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This simplifies the streamclient interface by removing the Dial method and moving the validation in Dial to interface construction time. Release note: none Epic: CRDB-40896
jeffswenson
force-pushed
the
jeffswenson-crosscluster-remove-dial
branch
from
a20ddc6 to
32b2ea2
Compare
dt
approved these changes
Jan 9, 2025
|
Thanks for the review! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the streamclient interface by removing the Dial method and moving the validation in Dial to interface construction time.
Release note: none
Epic: CRDB-40896