Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.3: add columnar block cluster setting #138097

Merged
merged 2 commits into from
Jan 2, 2025
Merged

release-24.3: add columnar block cluster setting #138097

merged 2 commits into from
Jan 2, 2025

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Dec 30, 2024 •
edited
Loading

Revert the reverts that removed and made ineffectual the columnar block cluster setting storage.columnar_blocks.enabled. There is some additional testing work still ongoing (integration of columnar blocks into the Pebble metamorphic tests), but overall columnar blocks are considered stable now.

Close #133189.
Release justification: Enabling opt-in functionality to further de-risk columnar blocks ahead of 25.1.

@jbowens
Revert "release-24.3: storage: remove columnar cluster setting"
d9bc093 
This reverts commit a5c782f.

Epic: CRDB-37584
Informs cockroachdb#133189.
Release note: Introduces the `storage.columnar_blocks.enabled` cluster setting
allowing opting into the columnar block sstable format.
@jbowens jbowens requested a review from a team as a code owner December 30, 2024 22:31
@jbowens jbowens requested a review from sumeerbhola December 30, 2024 22:31
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 30, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 30, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 30, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@jbowens jbowens requested a review from RaduBerinde December 30, 2024 22:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

RaduBerinde
RaduBerinde approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

RaduBerinde
RaduBerinde reviewed Dec 31, 2024
View reviewed changes
pkg/storage/pebble.go Outdated
var columnarBlocksEnabled = settings.RegisterBoolSetting(
settings.SystemVisible,
"storage.columnar_blocks.enabled",
"set to true to enable columnar-blocks to store KVs in a columnar format",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add (experimental) to this description? (just on this branch)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jbowens
Revert "storage: disable columnar format completely"
f3f1eca 
This reverts commit 93e51ba.

Epic: CRDB-37584
Informs cockroachdb#133189.
Release note: none
jbowens
jbowens commented Jan 2, 2025
View reviewed changes
Copy link
Collaborator Author

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also made the value metamorphic on this branch too

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde and @sumeerbhola)

pkg/storage/pebble.go Outdated
var columnarBlocksEnabled = settings.RegisterBoolSetting(
settings.SystemVisible,
"storage.columnar_blocks.enabled",
"set to true to enable columnar-blocks to store KVs in a columnar format",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jbowens jbowens merged commit 05babc2 into cockroachdb:release-24.3 Jan 2, 2025
20 of 21 checks passed
@jbowens jbowens deleted the 24.3-col branch January 2, 2025 19:52
@jbowens
Copy link
Collaborator Author

jbowens commented Jan 2, 2025

TFTR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduBerinde RaduBerinde RaduBerinde approved these changes

@sumeerbhola sumeerbhola Awaiting requested review from sumeerbhola sumeerbhola is a code owner automatically assigned from cockroachdb/storage

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbowens @cockroach-teamcity @RaduBerinde