sql/distsqlrun: use FastIntSet to track unmatched right-side rows #21303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `[]bool` with `FastIntSet` for tracking unmatched right-side rows. The `FastIntSet` will avoid an allocation for the common case of less than 64 rows on the right-side. This only affects right and full outer joins. Fixes cockroachdb#21269 Release note: None
|
This change is |
|
I'm not aware of any benchmarks this affects. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
[]boolwithFastIntSetfor tracking unmatched right-siderows. The
FastIntSetwill avoid an allocation for the common case ofless than 64 rows on the right-side.
This only affects right and full outer joins.
Fixes #21269
Release note: None