sql: support arbitrary functions in FROM clauses #22314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
The last commit doesn't need a release note because it does the same as the 2nd one, and there wasn't a release in-between the two that would cause users to notice a difference. TFYR! Review status: 2 of 6 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
the ValuesClause is not really needed after planning. Remove it. Release note: none
The following is valid in pg's SQL dialect: ``` > SELECT * FROM cos(123) ``` i.e. any scalar function is a valid data source. This patch implements this in CockroachDB for compatibility. This is needed e.g. by TypeORM. Release note (sql change): scalar functions can now be used in FROM clauses.
Release note: none
|
cc @rytaft for semantic coverage in the opt builder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22312.
The following is valid in pg's SQL dialect:
i.e. any scalar function is a valid data source.
This patch implements this in CockroachDB for compatibility.
This is needed e.g. by TypeORM.
Release note (sql change): scalar functions can now be used
in FROM clauses.