Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli,sql: add another crutch to the handling of column types in dump #28949

Merged
merged 1 commit into from
Aug 23, 2018

Commits on Aug 23, 2018

  1. cli,sql: add another crutch to the handling of column types in dump

    There are major problems in `cockroach dump` described separately in
    cockroachdb#28948.
    
    Part of this is `cockroach dump` trying to reverse-engineering a datum
    type from the announced column type in `information_schema.columns`,
    by parsing the type name. Prior to this patch, this parsing was
    incomplete (it went out of sync with the SQL parser over time,
    naturally as it was bound to do).
    
    This entire approach is flawed, but this is no time to redesign
    `cockroach dump`. Instead, this patch re-syncs the dump-specific type
    parser with the general SQL parser.
    
    Release note (bug fix): `cockroach dump` is now again better able to
    operate across multiple CockroachDB versions.
    knz committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    2363d44 View commit details
    Browse the repository at this point in the history