Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: return one entry less in Entries #29579

Merged
merged 1 commit into from
Sep 6, 2018
Merged

storage: return one entry less in Entries #29579

merged 1 commit into from
Sep 6, 2018
+71 −39

Commits on Sep 6, 2018

  1. storage: return one entry less in Entries 

    This works around the bug outlined in:

etcd-io/etcd#10063

by matching Raft's internal implementation of commit pagination.
Once the above PR lands, we can revert this commit (but I assume
that it will take a little bit), and I think we should do that
because the code hasn't gotten any nicer to look at.

Fixes cockroachdb#28918.

Release note: None
    @tbg
    tbg committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9d46451 View commit details
    Browse the repository at this point in the history