Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.1: backport raft bug workaround and cli debug improvement #29666

Merged
merged 2 commits into from
Sep 6, 2018

Conversation

tbg
Copy link
Member

@tbg tbg commented Sep 6, 2018

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

This works around the bug outlined in:

etcd-io/etcd#10063

by matching Raft's internal implementation of commit pagination.
Once the above PR lands, we can revert this commit (but I assume
that it will take a little bit), and I think we should do that
because the code hasn't gotten any nicer to look at.

Fixes cockroachdb#28918.

Release note: None
@tbg tbg requested a review from a team as a code owner September 6, 2018 19:20
@tbg tbg requested a review from a team September 6, 2018 19:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@tbg tbg merged commit 55e69bb into cockroachdb:release-2.1 Sep 6, 2018
@tbg tbg deleted the backport2.1-29579-29631 branch September 6, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants