Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: add ramp period to tpcc/nodes=3/w=max #30941

Merged
merged 1 commit into from
Oct 4, 2018
Merged

roachtest: add ramp period to tpcc/nodes=3/w=max #30941

merged 1 commit into from
Oct 4, 2018

Conversation

nvanbenschoten
Copy link
Member

Fixes #30886.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Oct 4, 2018
@nvanbenschoten
Merge #30941
e48fc71 
30941: roachtest: add ramp period to tpcc/nodes=3/w=max r=nvanbenschoten a=nvanbenschoten

Fixes #30886.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Contributor

craig bot commented Oct 4, 2018

Build succeeded

@craig craig bot merged commit 1383180 into cockroachdb:master Oct 4, 2018
@tbg
Copy link
Member

tbg commented Oct 4, 2018

Why does this fix it?

@nvanbenschoten
Copy link
Member Author

I actually don't think it does. I was able to reproduce very high latencies without the --ramp period, like we see in #30886 (comment), but not the complete deadlock, like we see in #30886 (comment). However, in a completely unrelated test (with --ramp, FWIW) I was able to reproduce the deadlock and spent some time debugging it last night. I haven't gotten to the bottom of it yet. I'll re-open the issue.

@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/tpccRamp branch October 4, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhhz danhhz danhhz approved these changes

@tbg tbg Awaiting requested review from tbg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvanbenschoten @cockroach-teamcity @tbg @danhhz