sql: deflake partition test again #33084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RandDatum function could still occasionally return datums with invalid column types, such as arrays with unknown-typed elements. This should fix things once and for all, and cleans up the code a bit as well. Release note: None
|
This change is |
|
LGTM, thanks for fixing! |
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 13, 2018
33084: sql: deflake partition test again r=jordanlewis a=jordanlewis The RandDatum function could still occasionally return datums with invalid column types, such as arrays with unknown-typed elements. This should fix things once and for all, and cleans up the code a bit as well. Closes #32889. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RandDatum function could still occasionally return datums with
invalid column types, such as arrays with unknown-typed elements. This
should fix things once and for all, and cleans up the code a bit as
well.
Closes #32889.
Release note: None