sql: Uopdate unimplemented reference #33144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also clean up the wording to be more explicit. The error for not being able to add a reference via alter was pointing to the incorrect github ID cockroachdb#8855. It's been updated to point to cockroachdb#32917 instead. Release note: None
|
This change is |
knz
approved these changes
Dec 13, 2018
|
Thanks for the quick review. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 13, 2018
33144: sql: Uopdate unimplemented reference r=BramGruneir a=BramGruneir And also clean up the wording to be more explicit. The error for not being able to add a reference via alter was pointing to the incorrect github ID #8855. It's been updated to point to #32917 instead. Release note: None Co-authored-by: Bram Gruneir <bram@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also clean up the wording to be more explicit.
The error for not being able to add a reference via alter was pointing to the
incorrect github ID #8855. It's been updated to point to #32917 instead.
Release note: None