Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix schema change cancel test #33703

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

vivekmenezes
Copy link
Contributor

@vivekmenezes vivekmenezes commented Jan 14, 2019

Speed up the test by reducing the fraction of data that is processed
by the backfill before issuing a cancel.

Make the test easier to understand.

Wait enough time for the rollback to complete processing.

fixes #33335

@vivekmenezes vivekmenezes requested review from dt and a team January 14, 2019 03:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@vivekmenezes
Copy link
Contributor Author

bors r+

@vivekmenezes
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 15, 2019

Build failed

Speed up the test by reducing the fraction of data that is processed
by the backfill before issuing a cancel.

Make the test easier to understand.

Wait enough time for the rollback to complete processing.

fixes cockroachdb#33335

Release note: None
@vivekmenezes
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jan 16, 2019
33703:  roachtest: fix schema change cancel test r=vivekmenezes a=vivekmenezes

Speed up the test by reducing the fraction of data that is processed
by the backfill before issuing a cancel.

Make the test easier to understand.

Wait enough time for the rollback to complete processing.

fixes #33335

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jan 16, 2019

Build succeeded

@craig craig bot merged commit c04d2fa into cockroachdb:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: schemachange/indexrollback/tpcc-1000 failed
3 participants