Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: rework TestClusterVersionBootstrapStrict #34651

Commits on Feb 6, 2019

  1. server: rework TestClusterVersionBootstrapStrict

    This test... I'm not entirely sure what it was supposed to test to be
    honest, but it seemed to be more complicated than it needed to be. It
    forced and emphasized MinSupportedVersion being equal to
    BinaryServerVersion (which is generally not a thing). I've simplified
    it, making it not muck with the versions, while keep (I think) the
    things it was testing (to the extent that it was testing anything).
    
    This test was also in my way because it created servers that pretended
    to be versions that are not technically supported by the binary, and
    this kind of funkiness is making my life hard as I'm trying to rework
    the way in which versions are propagated and what knobs servers have,
    etc.
    
    Release note: None
    andreimatei committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    f28ae31 View commit details
    Browse the repository at this point in the history