sql: accept+ignore precision 6 on TIME,TIMESTAMP,TIMESTAMPTZ #35128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): CockroachDB now recognizes the syntax `TIME(6)`, `TIMESTAMP(6)` and `TIMESTAMPTZ(6)` / `TIMESTAMP(6) WITH TIME ZONE`, for compatibility with PostgreSQL. Only the value 6 is supported (which is also the default in PostgreSQL). When used for a table column definition, the precision is not stored and it is not possible to distinguish types with and without specified precisions in the introspection metadata.
|
This change is |
maddyblue
approved these changes
Feb 21, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 21, 2019
35128: sql: accept+ignore precision 6 on TIME,TIMESTAMP,TIMESTAMPTZ r=knz a=knz Informs #32098. Informs #32565. This is not the full feature but might unlock Flowable compat. cc @rolandcrosby @awoods187 @drewdeally Release note (sql change): CockroachDB now recognizes the syntax `TIME(6)`, `TIMESTAMP(6)` and `TIMESTAMPTZ(6)` / `TIMESTAMP(6) WITH TIME ZONE`, for compatibility with PostgreSQL. Only the value 6 is supported (which is also the default in PostgreSQL). When used for a table column definition, the precision is not stored and it is not possible to distinguish types with and without specified precisions in the introspection metadata. Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #32098.
Informs #32565.
This is not the full feature but might unlock Flowable compat. cc @rolandcrosby @awoods187 @drewdeally
Release note (sql change): CockroachDB now recognizes the syntax
TIME(6),TIMESTAMP(6)andTIMESTAMPTZ(6)/TIMESTAMP(6) WITH TIME ZONE, for compatibility with PostgreSQL. Only the value 6 issupported (which is also the default in PostgreSQL). When used for a
table column definition, the precision is not stored and it is not
possible to distinguish types with and without specified precisions in
the introspection metadata.