pgwire: add counter metric to track number of incoming connections #35547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clusters experience problems they can sometimes receive floods of new sql connections. We currently don't have visibility in to the rate of new connections. This metric can help understand whether traffic for things like internal-get-hashed-pwd is due to faulty logic in that component or to legitimate load due to an increase in connections. Release note: None
|
This change is |
tbg
reviewed
Mar 11, 2019
I'm not sure this is a primary indicator of things being unhealthy. I wouldn't have a good intuition about the right value to set that to. Imagine a client who never reuses a connections as seeing a pretty high rate here but isn't necessarily in a bad state. |
|
@tbg I just went looking for this metric and realized I hadn't merged this. May I? |
|
Yep!
…On Fri, May 24, 2019, 16:09 ajwerner ***@***.***> wrote:
@tbg <https://github.com/tbg> I just went looking for this metric and
realized I hadn't merged this. May I?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35547?email_source=notifications&email_token=ABGXPZCC3DOWVBF2MZDETR3PW7ZJBA5CNFSM4G4WTKD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFPHYI#issuecomment-495645665>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGXPZDMG7GKEPJLBJB5DP3PW7ZJBANCNFSM4G4WTKDQ>
.
|
|
bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
May 24, 2019
35547: pgwire: add counter metric to track number of incoming connections r=tbg a=ajwerner When clusters experience problems they can sometimes receive floods of new sql connections. We currently don't have visibility in to the rate of new connections. This metric can help understand whether traffic for things like internal-get-hashed-pwd is due to faulty logic in that component or to legitimate load due to an increase in connections. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clusters experience problems they can sometimes receive floods of new sql
connections. We currently don't have visibility in to the rate of new
connections. This metric can help understand whether traffic for things like
internal-get-hashed-pwd is due to faulty logic in that component or to
legitimate load due to an increase in connections.
Release note: None