workload/tpcc: limit parallelism for worker initialization #36913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a semaphore to avoid initializing all workers in parallel - for 10k warehouses, we have 100k workers and that can lead to OOM. Fixes cockroachdb#36897. Release note: None
|
This change is |
bdarnell
approved these changes
Apr 17, 2019
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 18, 2019
36913: workload/tpcc: limit parallelism for worker initialization r=RaduBerinde a=RaduBerinde Add a semaphore to avoid initializing all workers in parallel - for 10k warehouses, we have 100k workers and that can lead to OOM. Fixes #36897. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a semaphore to avoid initializing all workers in parallel - for
10k warehouses, we have 100k workers and that can lead to OOM.
Fixes #36897.
Release note: None