Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Don't swallow ErrEpochAlreadyIncremented #36942

Merged
merged 1 commit into from
Apr 19, 2019

Commits on Apr 19, 2019

  1. storage: Don't swallow ErrEpochAlreadyIncremented

    IncrementEpoch was failing to distinguish between the request that
    caused the increment and another caller making the same increment.
    This is incorrect since a successful increment tells you *when* the
    node was confirmed dead, while relying on another node's increment
    leaves this uncertain.
    
    In rare cases involving a badly overloaded cluster, this could result
    in inconsistencies (non-serializable transactions) due to incorrect
    timestamp cache management.
    
    Fixes cockroachdb#35986
    
    Release note (bug fix): Fix a rare inconsistency that could occur on
    badly overloaded clusters.
    bdarnell committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    8de884a View commit details
    Browse the repository at this point in the history