roachtest: misc fixes #37032
roachtest: misc fixes #37032
Conversation
Closes cockroachdb#36596. Release note: None
The hack is necessary since subtests silently ignore the MinVersion field. See cockroachdb#36752. Release note: None
Fixes cockroachdb#36978. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @petermattis and @tbg)
pkg/cmd/roachtest/acceptance.go, line 34 at r2 (raw file):
fn func(ctx context.Context, t *test, c *cluster) skip string // roachtest needs to be taught about MinVersion for subtests.
Add TODO(bobvawter). I don't think this is particularly difficult to do.
pkg/cmd/roachtest/backup.go, line 33 at r3 (raw file):
Name: fmt.Sprintf("backup2TB/%s", backup2TBSpec), Cluster: backup2TBSpec, MinVersion: "v19.1.0",
I looked in #36978, but didn't see a reason this test can only run on 19.1. What obvious thing am I missing?
There was a problem hiding this comment.
TFTR, I'll follow up on the backup test on 2.1.
bors r=petermattis
Reviewable status:
pkg/cmd/roachtest/acceptance.go, line 34 at r2 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Add
TODO(bobvawter). I don't think this is particularly difficult to do.
The issue is assigned to him. I mention there to remove this hack.
pkg/cmd/roachtest/backup.go, line 33 at r3 (raw file):
Previously, petermattis (Peter Mattis) wrote…
I looked in #36978, but didn't see a reason this test can only run on
19.1. What obvious thing am I missing?
pq: unsupported storage scheme: "experimental-workload"
@danhhz I searched Slack for the incantation to use the csv server, but found nothing that I didn't think I'd have to tinker with, mind reminding me of the right thing to do here so that we can keep this test on 2.1?
Build failed |
|
bors r=petermattis OOM in TestVet Using #37061 to track. |
Build failed |
|
bors r=petermattis |
Build failed |
|
Sigh... another new one, #37073 Will this PR find all the flakes? Let's find out bors r=petermattis |
37032: roachtest: misc fixes r=petermattis a=tbg roachtest: run backup test on 19.1 and upwards only Fixes #36978. roachtest: really skip version-upgrade on 2.1 (via hack) The hack is necessary since subtests silently ignore the MinVersion field. See #36752. acceptance: add debugging to acceptance/cli/node-status Closes #36596. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/backup.go, line 33 at r3 (raw file):
Previously, tbg (Tobias Grieger) wrote…
pq: unsupported storage scheme: "experimental-workload"
@danhhz I searched Slack for the incantation to use the csv server, but found nothing that I didn't think I'd have to tinker with, mind reminding me of the right thing to do here so that we can keep this test on 2.1?
I went to write this up, but it looks like the --csv-server arg was only ever hooked up to fixtures make and not to fixtures import. 🤦♂️ PR incoming
Once that's merged, this should work:
roachprod run cluster -- "./workload csv-server --port=8081 &> logs/workload-csv-server.log < /dev/null &"
roachprod run cluster:1 -- "./workload fixtures import tpcc --csv-server=http://localhost:8081"
roachtest: run backup test on 19.1 and upwards only
Fixes #36978.
roachtest: really skip version-upgrade on 2.1 (via hack)
The hack is necessary since subtests silently ignore the MinVersion field.
See #36752.
acceptance: add debugging to acceptance/cli/node-status
Closes #36596.
Release note: None