roachprod: keyscan from a single host and distribute known_hosts #37077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR we would run ssh-keyscan in parallel on all of the hosts. I suspect the retry loop in the keyscan script is to deal with the connection failures which cockroachdb#37001 attempts to mitigate but I don't feel eager to rip them out right now. In addition to performing the keyscan from a single host and distributing to all, this change also distributes the known_hosts file to the shared user in anticipation of further changes to enable the shared user to become the default user for roachprod commands with gce. Release note: None
|
This change is |
petermattis
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Yes I verified that it works on both bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
37077: roachprod: keyscan from a single host and distribute known_hosts r=ajwerner a=ajwerner Before this PR we would run ssh-keyscan in parallel on all of the hosts. I suspect the retry loop in the keyscan script is to deal with the connection failures which #37001 attempts to mitigate but I don't feel eager to rip them out right now. In addition to performing the keyscan from a single host and distributing to all, this change also distributes the known_hosts file to the shared user in anticipation of further changes to enable the shared user to become the default user for roachprod commands with gce. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
May 10, 2019
Previously in cockroachdb#35759 logic was added to read public keys from the gce project metadata and distribute them into the authorized_keys file of the shared user (ubuntu) on AWS. cockroachdb#37077 primarily served to distribute known_hosts files to the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE. That change also included logic to write the authorized_keys file to the shared user on GCE (as opposed to just AWS) in anticipation of switching roachprod to use the shared user across cloud providers. This change extends the previous change by also distributing all public keys to the authorized_keys file for the cluster creating user on GCE. Release note: None
ajwerner
added a commit
that referenced
this pull request
Jun 4, 2019
Previously in #35759 logic was added to read public keys from the gce project metadata and distribute them into the authorized_keys file of the shared user (ubuntu) on AWS. #37077 primarily served to distribute known_hosts files to the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE. That change also included logic to write the authorized_keys file to the shared user on GCE (as opposed to just AWS) in anticipation of switching roachprod to use the shared user across cloud providers. This change extends the previous change by also distributing all public keys to the authorized_keys file for the cluster creating user on GCE. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 4, 2019
37438: roachprod: distribute authorized_keys to creating user on gce r=ajwerner a=ajwerner Previously in #35759 logic was added to read public keys from the gce project metadata and distribute them into the authorized_keys file of the shared user (ubuntu) on AWS. #37077 primarily served to distribute known_hosts files to the shared user (ubuntu) on both AWS and GCE as well as the creating user on GCE. That change also included logic to write the authorized_keys file to the shared user on GCE (as opposed to just AWS) in anticipation of switching roachprod to use the shared user across cloud providers. This change extends the previous change by also distributing all public keys to the authorized_keys file for the cluster creating user on GCE. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we would run ssh-keyscan in parallel on all of the hosts.
I suspect the retry loop in the keyscan script is to deal with the connection
failures which #37001 attempts to mitigate but I don't feel eager to rip them
out right now. In addition to performing the keyscan from a single host and
distributing to all, this change also distributes the known_hosts file to the
shared user in anticipation of further changes to enable the shared user to
become the default user for roachprod commands with gce.
Release note: None