sql: fix checking for presence of window functions in some edge cases #37130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a window function was a part of another expression (say BinaryExpr) instead of being used directly within PARTITION BY and ORDER BY clauses of another window function, we would incorrectly not reject such a query and would actually crash while trying to execute it. Release note: None
|
This change is |
justinj
reviewed
Apr 25, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj)
|
Thanks for spotting this bug and for the review! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 25, 2019
37101: sql: add errorIfRows node r=yuzefovich a=yuzefovich Add errorIfRows node that returns an error if it receives a row from its input. It is needed for foreign keys checks implementation with joins. Fixes: #37053. I'm not sure whether some of these additions are necessary or if something is missing. Also, I'm not sure whether it deserves a unit test. Release note: None 37130: sql: fix checking for presence of window functions in some edge cases r=yuzefovich a=yuzefovich Previously, when a window function was a part of another expression (say BinaryExpr) instead of being used directly within PARTITION BY and ORDER BY clauses of another window function, we would incorrectly not reject such a query and would actually crash while trying to execute it. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a window function was a part of another expression
(say BinaryExpr) instead of being used directly within PARTITION BY
and ORDER BY clauses of another window function, we would incorrectly
not reject such a query and would actually crash while trying to
execute it.
Release note: None