Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: metrics improvements #37140

Merged
merged 2 commits into from
May 1, 2019
Merged

storage: metrics improvements #37140

merged 2 commits into from
May 1, 2019

Conversation

andreimatei
Copy link
Contributor

see individual commits

@andreimatei
storage: don't record empty batch in the RaftLogCommitLatency metric
7e7733a 
Some Raft commands are empty and don't require an fsync. These are
useless to measure and skewing the lower percentiles for that metric.

Release note: None
@andreimatei
ui: add 50% of raft commit latency and command latency to dashboard
338cde1 
We only had the 99%ile. A lower percentile seems useful too.
Also made the tooltips more descriptive.

Release note: None
@andreimatei andreimatei requested review from ajwerner, nvanbenschoten and a team April 25, 2019 19:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)

andreimatei
andreimatei commented May 1, 2019
View reviewed changes
Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)

@craig
Copy link
Contributor

craig bot commented May 1, 2019

Build failed

@andreimatei
Copy link
Contributor Author

andreimatei commented May 1, 2019 via email

craig bot pushed a commit that referenced this pull request May 1, 2019
@andreimatei
Merge #37140
e077d81 
37140: storage: metrics improvements r=andreimatei a=andreimatei

see individual commits

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented May 1, 2019

Build succeeded

@craig craig bot merged commit 338cde1 into cockroachdb:master May 1, 2019
@andreimatei andreimatei deleted the small.commit-latency-metrics branch May 6, 2019 22:29
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreimatei @cockroach-teamcity @ajwerner