c-deps: bump rocksdb for multiple backported PRs #37172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the following changes, all of which have landed upstream. - cockroachdb/rocksdb#27: "ldb: set `total_order_seek` for scans" - cockroachdb/rocksdb#28: "Fix cockroachdb#3840: only `SyncClosedLogs` for multiple CFs" - cockroachdb/rocksdb#29: "Optionally wait on bytes_per_sync to smooth I/O" - cockroachdb/rocksdb#30: "Option string/map/file can set env from object registry" Also made the RocksDB changes that we decided in cockroachdb#34897: - Do not sync WAL before installing flush result. This is achieved by backporting cockroachdb/rocksdb#28; no configuration change is necessary. - Do not sync WAL ever for temp stores. This is achieved by setting `wal_bytes_per_sync = 0`. - Limit size of final syncs when generating SSTs. This is achieved by backporting cockroachdb/rocksdb#29 and turning it on with `strict_bytes_per_sync = true`. Release note: None
|
This change is |
petermattis
approved these changes
Apr 27, 2019
| options.strict_bytes_per_sync = true; | ||
| // Do not sync the WAL periodically. We sync it every write already by calling | ||
| // `FlushWAL(true)` on non-temp stores. On the temp store we do not intend to | ||
| // sync WAL ever, so setting it to zero is fine there too. |
There was a problem hiding this comment.
While we don't intend to sync the WAL on temp-stores, I wonder if not syncing can run into problems where the WAL dirty data forces the OS to flush. Hopefully we're deleting the WAL before that happens, though. Ok, I just talked myself into being ok with this.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 27, 2019
37172: c-deps: bump rocksdb for multiple backported PRs r=ajkr a=ajkr Includes the following changes, all of which have landed upstream. - cockroachdb/rocksdb#27: "ldb: set `total_order_seek` for scans" - cockroachdb/rocksdb#28: "Fix #3840: only `SyncClosedLogs` for multiple CFs" - cockroachdb/rocksdb#29: "Optionally wait on bytes_per_sync to smooth I/O" - cockroachdb/rocksdb#30: "Option string/map/file can set env from object registry" Also made the RocksDB changes that we decided in #34897: - Do not sync WAL before installing flush result. This is achieved by backporting cockroachdb/rocksdb#28; no configuration change is necessary. - Do not sync WAL ever for temp stores. This is achieved by setting `wal_bytes_per_sync = 0`. - Limit size of final syncs when generating SSTs. This is achieved by backporting cockroachdb/rocksdb#29 and turning it on with `strict_bytes_per_sync = true`. Release note: None Co-authored-by: Andrew Kryczka <andrew.kryczka2@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes, all of which have landed upstream.
total_order_seekfor scans rocksdb#27: "ldb: settotal_order_seekfor scans"SyncClosedLogsfor multiple CFs (#4460) rocksdb#28: "Fix Failed tests (11329): #3840: onlySyncClosedLogsfor multiple CFs"Also made the RocksDB changes that we decided in #34897:
SyncClosedLogsfor multiple CFs (#4460) rocksdb#28; no configuration change is necessary.wal_bytes_per_sync = 0.strict_bytes_per_sync = true.Release note: None