server: add metadata for cloud provider and instance class to diagnostics #37272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
May 11, 2019
|
For the cloud storage stuff, what we did was write tests that check env vars that configured a given cloud and then call skip on the test if they're missing. That meant the tests are usually skipped which isn't great but if you run them by hand on a given cloud, you can confirm it works as expected. I like testing against the captured string snapshots here since that can be run anywhere, but similar skipped-if-not-on-aws tests could complement them (though I wouldn't hold up this change for them) |
Track the cloud provider and the machine type for nodes in the diagnostics report at /_status/diagnostics/local. Include tooling to capture this data for VMs running on AWS, GCP, and Azure. Release note: None
|
@dt Can I get you to take a quick peek at the |
dt
approved these changes
May 29, 2019
|
whoops, sorry I didn't notice the revisions! |
|
bors r+ |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 3, 2019
37272: server: add metadata for cloud provider and instance class to diagnostics r=sploiselle a=sploiselle Track the cloud provider and the machine type for nodes in the diagnostics report at `/_status/diagnostics/local`. Include tooling to capture this data for VMs running on AWS, GCP, and Azure. All other platforms return empty strings. @dt @BramGruneir Do we have anything that would let us simply test the metadata endpoints that this code uses, given that they're internal to remote VMs? Release note: None Co-authored-by: Sean Loiselle <himself@seanloiselle.com>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jul 2, 2019
38008: server: add metadata for cloud provider region to diagnostics r=sploiselle a=sploiselle Track the name of the cloud provider's region where nodes are located at `/_status/diagnostics/local`. Include functions to capture this data for VMs running on AWS, GCP, and Azure. All other platforms return empty strings. Also refactor prior PR (#37272) with a more modular/extensible design. Co-authored-by: Sean Loiselle <himself@seanloiselle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the cloud provider and the machine type for nodes in the diagnostics report at
/_status/diagnostics/local. Include tooling to capture this data for VMs running on AWS, GCP, and Azure. All other platforms return empty strings.@dt @BramGruneir Do we have anything that would let us simply test the metadata endpoints that this code uses, given that they're internal to remote VMs?
Release note: None