Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: don't try to make stats for dropped tables #38185

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

jordanlewis
Copy link
Member

Previously, statistics collection would schedule checks for all tables
at startup, including tables that have already been dropped. This was
harmless but polluted the logs and lease caches.

Now, statistics collection doesn't try to schedule checks for tables
that are known to have been dropped already.

Release note: None

Previously, statistics collection would schedule checks for all tables
at startup, including tables that have already been dropped. This was
harmless but polluted the logs and lease caches.

Now, statistics collection doesn't try to schedule checks for tables
that are known to have been dropped already.

Release note: None
@jordanlewis jordanlewis requested a review from a team as a code owner June 17, 2019 00:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@awoods187
Copy link
Contributor

Nice!

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

@jordanlewis
Copy link
Member Author

TFTR!

bors r+

craig bot pushed a commit that referenced this pull request Jun 17, 2019
38185: stats: don't try to make stats for dropped tables r=jordanlewis a=jordanlewis

Previously, statistics collection would schedule checks for all tables
at startup, including tables that have already been dropped. This was
harmless but polluted the logs and lease caches.

Now, statistics collection doesn't try to schedule checks for tables
that are known to have been dropped already.

Release note: None

Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
@craig
Copy link
Contributor

craig bot commented Jun 17, 2019

Build succeeded

@craig craig bot merged commit 15d2a52 into cockroachdb:master Jun 17, 2019
@jordanlewis jordanlewis deleted the stats-dropped branch June 18, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants