storage/tscache: save 4 bytes per encoded tscache value #38214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unsafe.Sizeof(hlc.Timestamp{})` was including XXX_sizecache, which was bloating
the struct size even though it didn't have an effect on the encoded size of the
timestamps, which we control in `encodeValue`.
Even once we remove `XXX_sizecache` (cockroachdb#37706), it looks like `unsafe.Sizeof` will
still include padding which we don't want to capture in the `encodedTsSize` constant,
so this seems like the best approach. See https://play.golang.org/p/5swJSSbP6J4.
Release note: None
|
This change is |
ajwerner
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r=ajwerner |
craig bot
pushed a commit
that referenced
this pull request
Jun 17, 2019
38197: cli: warn the user if the time zone database is unavailable r=knz a=knz Fixes #23828. (The part in that issue about the database not being up to date cannot be fixed using the Go standard library - this does not give access to the search path and the version number. A comprehensive fix needs to wait for #36864.) Release note (cli change): CockroachDB will now print out an error message and an informative hint if the time zone database is unusable. 38214: storage/tscache: save 4 bytes per encoded tscache value r=ajwerner a=nvanbenschoten `unsafe.Sizeof(hlc.Timestamp{})` was including XXX_sizecache, which was bloating the struct size even though it didn't have an effect on the encoded size of the timestamps, which we control in `encodeValue`. Even once we remove `XXX_sizecache` (#37706), it looks like `unsafe.Sizeof` will still include padding which we don't want to capture in the `encodedTsSize` constant, so this seems like the best approach. See https://play.golang.org/p/5swJSSbP6J4. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsafe.Sizeof(hlc.Timestamp{})was including XXX_sizecache, which was bloatingthe struct size even though it didn't have an effect on the encoded size of the
timestamps, which we control in
encodeValue.Even once we remove
XXX_sizecache(#37706), it looks likeunsafe.Sizeofwillstill include padding which we don't want to capture in the
encodedTsSizeconstant,so this seems like the best approach. See https://play.golang.org/p/5swJSSbP6J4.
Release note: None