sql: fix double-adding FK backreferences when retrying #38377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
force-pushed
the
fix-publish
branch
3 times, most recently
from
a7a42d5
to
72b0ef5
Compare
Currently, `PublishMultiple()` on the lease manager, which updates multiple table descriptors in a single transaction as part of a schema change, updates each table descriptor independently of the others. There was a bug where if the call to `PublishMultiple()` to add FKs and backreferences was retried (e.g., if there was a crash after this step but before the finalization of the schema change), we would correctly avoid re-adding the reference to the table, but the backreferences would be incorrectly added a second time. This change updates the interface of `PublishMultiple()`: There's now a single update closure which has access to a map of all table descriptors being modified. Backreferences are now only installed if the forward reference was also installed. Release note: None
dt
approved these changes
Jun 25, 2019
|
TFTR bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
38377: sql: fix double-adding FK backreferences when retrying r=lucy-zhang a=lucy-zhang Currently, `PublishMultiple()` on the lease manager, which updates multiple table descriptors in a single transaction as part of a schema change, updates each table descriptor independently of the others. There was a bug where if the call to `PublishMultiple()` to add FKs and backreferences was retried (e.g., if there was a crash after this step but before the finalization of the schema change), we would correctly avoid re-adding the reference to the table, but the backreferences would be incorrectly added a second time. This change updates the interface of `PublishMultiple()`: There's now a single update closure which has access to a map of all table descriptors being modified. Backreferences are now only installed if the forward reference was also installed. Release note: None 38382: sql: add support for NOT VALID check constraints r=Tyler314 a=Tyler314 Mark constraint as unvalidated if user specifies NOT VALID in their check constraint. Within backfill, do not add the unvalidated constraints to the queues for validating. Release note (sql change): Support NOT VALID for check constraints, which supports not checking constraints for existing rows. Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com> Co-authored-by: Tyler314 <tyler@cockroachlabs.com>
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
38377: sql: fix double-adding FK backreferences when retrying r=lucy-zhang a=lucy-zhang Currently, `PublishMultiple()` on the lease manager, which updates multiple table descriptors in a single transaction as part of a schema change, updates each table descriptor independently of the others. There was a bug where if the call to `PublishMultiple()` to add FKs and backreferences was retried (e.g., if there was a crash after this step but before the finalization of the schema change), we would correctly avoid re-adding the reference to the table, but the backreferences would be incorrectly added a second time. This change updates the interface of `PublishMultiple()`: There's now a single update closure which has access to a map of all table descriptors being modified. Backreferences are now only installed if the forward reference was also installed. Release note: None Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
PublishMultiple()on the lease manager, which updates multipletable descriptors in a single transaction as part of a schema change, updates
each table descriptor independently of the others. There was a bug where if the
call to
PublishMultiple()to add FKs and backreferences was retried (e.g., ifthere was a crash after this step but before the finalization of the schema
change), we would correctly avoid re-adding the reference to the table, but the
backreferences would be incorrectly added a second time.
This change updates the interface of
PublishMultiple(): There's now a singleupdate closure which has access to a map of all table descriptors being
modified. Backreferences are now only installed if the forward reference was
also installed.
Release note: None