Revert "deps: configure and build patched libedit" #38383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 454f32b. It breaks the Publish Bleeding Edge build, which blocks releases, nightly tests, and roachperf data collection. Looks like the failure is that it's trying to build libedit on windows: cockroachdb#32623 (comment) Release note: None
|
This change is |
|
LGTM. Hopefully we can re-revert this soon - I really want that libedit fix. |
|
Yeah, agreed. It probably wouldn't be too hard for one of us to unrevert and do what nikhil describes in #32623 (comment) In the meantime, let's get everything unblocked. bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Jun 24, 2019
38383: Revert "deps: configure and build patched libedit" r=jordanlewis a=danhhz This reverts commit 454f32b. It breaks the Publish Bleeding Edge build, which blocks releases, nightly tests, and roachperf data collection. Looks like the failure is that it's trying to build libedit on windows: #32623 (comment) Release note: None Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 454f32b. It breaks
the Publish Bleeding Edge build, which blocks releases, nightly tests,
and roachperf data collection.
Looks like the failure is that it's trying to build libedit on windows:
#32623 (comment)
Release note: None