deps: configure and build patched libedit redux #38400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a04596. Release note: None
Libedit doesn't support Windows, so don't try to build/link it there. This was the previous behavior, but I broke it in cockroachdb#32623. Release note: None
|
This change is |
benesch
changed the title
jordanlewis
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @jordanlewis)
|
Second time's the charm! 😬 bors r=jordanlewis |
|
omg Bors I do not miss you one bit bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
38400: deps: configure and build patched libedit redux r=jordanlewis a=benesch Resubmit #32623 with a patch to avoid building libedit on Windows, where it's unsupported. I've verified that `build/builder.sh mkrelease windows` succeeds with this additional patch. Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit #32623 with a patch to avoid building libedit on Windows, where it's unsupported. I've verified that
build/builder.sh mkrelease windowssucceeds with this additional patch.