exec: fix bug in ordered aggregate planning #38512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
approved these changes
Jun 27, 2019
yuzefovich
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
Thanks!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/exec/aggregator.go, line 130 at r1 (raw file):
} groupTypes := extractGroupTypes(groupCols, colTypes)
I think extractGroupTypes is unused now, so it should be removed.
Previously, there was a bug that caused ordered aggregations to not be planned correctly when some columns weren't present in the grouping columns. Release note: None
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 27, 2019
38512: exec: fix bug in ordered aggregate planning r=jordanlewis a=jordanlewis Previously, there was a bug that caused ordered aggregations to not be planned correctly when some columns weren't present in the grouping columns. Fixes #37332. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a bug that caused ordered aggregations to not be
planned correctly when some columns weren't present in the grouping
columns.
Fixes #37332.
Release note: None