Commits on Jul 9, 2019

1. opt: fix panic recovery for error handling …

   The major entry points in the optimizer catch all panics that throw an
   error and converts them to errors. Unfortunately, this also catches
   runtime errors (in which case we convert them to errors and lose the
   stack trace).
   
   This change adds a `ShouldCatch` helper which determines if we should
   return a thrown object as an error. If the object is a
   `runtime.Error`, it gets wrapped by an AssertionFailed error which
   will cause correct error handling (stack trace, sentry reporting, etc).
   
   As part of this change, we are also removing wrappers like
   `builderError`, which are no longer useful. We fix the opt tester to
   fail with the full error information (using `%+v`) for assertion
   errors.
   
   Release note: None

   

   RaduBerinde committed Jul 9, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 5ab44a9
   • Browse repository at this point

   Copy the full SHA

   5ab44a9 View commit details

   Browse the repository at this point in the history