ui: show unintended flatten graph in better way #38574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like RocksDB Compactions/Flushs graphs, they have < 1 values at all. Thus their graph always would be displayed flatten to zero. It makes hard to distinguish when it occured or not. This patch lower the countIncrementTable from 0.1 to 0.01 and modify calculateYAxisDomain not to align its legend to [0, 1]. Release note: None
|
This change is |
|
@vilterp @piyush-singh who can review this? |
|
I'll take a look at the changes by deploying a branch, will follow up with any comments. Deferring to Pete for the code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
RocksDB Compactions/Flushsgraphs, they have < 1 values at all.Thus their graph always would be displayed flatten to zero. It makes hard to distinguish when it occurred or not.
This patch lower the
countIncrementTablefrom 0.1 to 0.01 and modifycalculateYAxisDomainnot to align its legend to[0, 1].Ref:
This fixes #27094
After:
