exec: fix an error with vectorized testing infrastructure #38629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the output of an operator was compared against the output of a processor as set comparison (i.e. with any order of rows), we would accumulate the rows "as is" - without deep copy. But because the underlying memory is almost certain to be reused, we need to accumulate the copies of the output rows. Now this is fixed. Release note: None
|
This change is |
asubiotto
approved these changes
Jul 3, 2019
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2019
38629: exec: fix an error with vectorized testing infrastructure r=yuzefovich a=yuzefovich Previously, when the output of an operator was compared against the output of a processor as set comparison (i.e. with any order of rows), we would accumulate the rows "as is" - without deep copy. But because the underlying memory is almost certain to be reused, we need to accumulate the copies of the output rows. Now this is fixed. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the output of an operator was compared against
the output of a processor as set comparison (i.e. with any order
of rows), we would accumulate the rows "as is" - without deep copy.
But because the underlying memory is almost certain to be reused,
we need to accumulate the copies of the output rows. Now this is
fixed.
Release note: None