Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/dump: more clearly inform the user upon tables with no visible columns #38725

Merged
merged 2 commits into from
Jul 8, 2019
Merged

cli/dump: more clearly inform the user upon tables with no visible columns #38725

merged 2 commits into from
Jul 8, 2019

Commits on Jul 8, 2019

  1. cli/Main: show user details and hints included in error if available 

    Release note: None
    @knz
    knz committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    861dc40 View commit details
    Browse the repository at this point in the history

  2. cli/dump: inform the user clearly when dumping no-col tables 

    Before:

```
kena@kenax ~/cockroach % ./cockroach dump --insecure defaultdb
CREATE TABLE t (,
        FAMILY "primary" (rowid)
);
Error: pq: at or near "from": syntax error
Failed running "dump"
```

After:

```
kena@kenax ~/cockroach % ./cockroach dump --insecure defaultdb
CREATE TABLE t (,
        FAMILY "primary" (rowid)
);
Error: table "defaultdb.public.t" has no visible columns
HINT: To proceed with the dump, either omit this table from the list of tables to dump, drop the table, or add some visible columns.
--
See: cockroachdb#37768
Failed running "dump"
```

Release note (cli change): `cockroach dump` will now more clearly
refer to issue cockroachdb#37768 when it encounters a table with no visible
columns, which (currently) cannot be dumped successfully.
    @knz
    knz committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    d4b257b View commit details
    Browse the repository at this point in the history