roachtest: collect cluster logs after timed out tests #38740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Jul 8, 2019
| @@ -700,12 +679,42 @@ func (r *testRunner) runTest( | |||
| panic("expected success=false after a timeout") | |||
| } | |||
| case <-time.After(5 * time.Minute): | |||
| return false, fmt.Errorf("test timed out and afterwards failed to respond to cancelation") | |||
| msg := "test timed out and afterwards failed to respond to cancelation" | |||
Before this patch, a timed out test that wasn't reacting to its ctx cancelation was not attempting to collect node logs. Release note: None
andreimatei
force-pushed
the
roachtest.logs
branch
from
50ac113
to
506025d
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 8, 2019
38740: roachtest: collect cluster logs after timed out tests r=andreimatei a=andreimatei Before this patch, a timed out test that wasn't reacting to its ctx cancelation was not attempting to collect node logs. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, a timed out test that wasn't reacting to its ctx
cancelation was not attempting to collect node logs.
Release note: None