sql/exec: detail error objects when printing out warnings #38762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)
|
TFYR! |
Build failed |
Formatting with `%+v` reveals the internal structure of error objects and makes troubleshooting easier. Release note: None
|
woops there was a typo bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Jul 9, 2019
38748: opt: pass "columns are key" flag to lookup join execution r=RaduBerinde a=RaduBerinde Pass a flag that indicates that the lookup join is on a set of key columns (i.e. each lookup results in at most one row). As part of the same change, we add the lookup column information which was missing from the lookup join EXPLAIN. Fixes #38614. Release note (sql change): EXPLAIN returns more information about lookup joins. 38762: sql/exec: detail error objects when printing out warnings r=knz a=knz (I am sending this as a strawman limited to the `sql/exec` package. If we collectively find this useful, we can extend the idea to other packages and eventually add a linter to enforce.) Formatting with `%+v` reveals the internal structure of error objects and makes troubleshooting easier. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I am sending this as a strawman limited to the
sql/execpackage. If we collectively find this useful, we can extend the idea to other packages and eventually add a linter to enforce.)Formatting with
%+vreveals the internal structure of error objectsand makes troubleshooting easier.
Release note: None