exec: bail out on mixed type expressions #38816
Conversation
|
This change is |
There was a problem hiding this comment.
Nice!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @solongordon)
pkg/sql/logictest/testdata/logic_test/vectorize, line 410 at r1 (raw file):
0.5 # Test mixed types comparison. (Should also fail back.)
|
Empty comment was: "[nit]: |
|
Is it a question of templating mixed type projection/selection operators? |
There was a problem hiding this comment.
Is it a question of templating mixed type projection/selection operators?
Yes. Or perhaps we could support many of these cases by adding cast operators? In either case, it seems to me we can punt on this for 19.2.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/vectorize, line 410 at r1 (raw file):
Previously, yuzefovich wrote…
Done.
Since our vectorized projection and selection operators currently only handle homogeneous types, I added logic to the planner which detects mixed types and errors out. Fixes cockroachdb#38798 Release note: None
solongordon
force-pushed
the
vec-type-errors
branch
from
3987eac
to
908fe7b
Compare
|
bors r+ |
38816: exec: bail out on mixed type expressions r=solongordon a=solongordon Since our vectorized projection and selection operators currently only handle homogeneous types, I added logic to the planner which detects mixed types and errors out. Fixes #38798 Release note: None Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Since our vectorized projection and selection operators currently only
handle homogeneous types, I added logic to the planner which detects
mixed types and errors out.
Fixes #38798
Release note: None