exec: Add informative k/v tracing to cfetcher. #38938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
reviewed
Jul 17, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rohany)
pkg/sql/distsqlrun/column_exec_setup.go, line 644 at r1 (raw file):
for _, e := range t.Exprs { var err error // TODO: This could be done better, especially in the case of
nit: I thought our linters caught this, but it's a convention in our codebase to always have TODO(somebody).
pkg/sql/row/cfetcher.go, line 789 at r2 (raw file):
if idx != -1 { dVal := exec.PhysicalTypeColElemToDatum(rf.machine.colvecs[idx], rf.machine.rowIdx, rf.table.da, rf.table.keyValTypes[idx]) fmt.Println(dVal, dVal.String())
This probably needs to go away.
This PR adds more logging to the cfetcher so that it outputs the same logging information as the fetcher. Release note: None
|
bors r=jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
Jul 17, 2019
38938: exec: Add informative k/v tracing to cfetcher. r=jordanlewis a=rohany This PR adds K/V tracing similar to that of the distsql fetcher to the cfetcher used by the vectorized engine. For reviewing purposes, please look at the latest commit. This PR depends on a helper function added in the builtin functions support PR which has not landed yet. Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds K/V tracing similar to that of the distsql fetcher to the cfetcher used by the vectorized engine.
For reviewing purposes, please look at the latest commit. This PR depends on a helper function added in the builtin functions support PR which has not landed yet.