pkg: Allows no target cols to be specified in IMPORT INTO query. #39032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru27
force-pushed
the
no-target-cols-import-into
branch
from
9103c0f
to
70f9f17
Compare
dt
approved these changes
Jul 25, 2019
This is an add on to cockroachdb#39023. It adds the grammar required to support queries such as: `IMPORT INTO test CSV DATA ('...');` No target columns implies that all columns are imported into from the data sources. Release note: None
adityamaru27
force-pushed
the
no-target-cols-import-into
branch
from
70f9f17
to
844f55c
Compare
|
TFTR! |
craig bot
pushed a commit
that referenced
this pull request
Jul 29, 2019
39032: pkg: Allows no target cols to be specified in IMPORT INTO query. r=adityamaru27 a=adityamaru27
It adds the grammar required to support queries such as:
`IMPORT INTO test CSV DATA ('...');`
No target columns implies that all columns are imported into from the data sources.
39130: batcheval: check GCThreshold in RevertRange command r=dt a=dt
I think somehow I got mixed up about when a key is GC'ed in that original comment.
So that we can time-travel to any time within GC window, we already only GC a key
when there is a newer _expired_ key over it, and the requirements for being able
to revert to a time are no different than being able to read at that time, so the
same GCThreshold check we do elsewhere should also be good enough here.
Release note: none.
Co-authored-by: Aditya Maru <adityamaru@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds the grammar required to support queries such as:
IMPORT INTO test CSV DATA ('...');No target columns implies that all columns are imported into from the data sources.