sql: fix a bug with ordinality planning #39086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordinality node appends an Int column so that it can write to it. Previously, plan.ResultTypes were appended to before adding a single group stage which internally used updated ResultTypes to set up inputs to the ordinality processor. Now this behavior is fixed and adding a single group stage takes care of updating ResultTypes accordingly. Release note: None
|
This change is |
|
What happens at the moment is that |
jordanlewis
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 25, 2019
39086: sql: fix a bug with ordinality planning r=yuzefovich a=yuzefovich Ordinality node appends an Int column so that it can write to it. Previously, plan.ResultTypes were appended to before adding a single group stage which internally used updated ResultTypes to set up inputs to the ordinality processor. Now this behavior is fixed and adding a single group stage takes care of updating ResultTypes accordingly. Fixes: #38995. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordinality node appends an Int column so that it can write to it.
Previously, plan.ResultTypes were appended to before adding a
single group stage which internally used updated ResultTypes to
set up inputs to the ordinality processor. Now this behavior is
fixed and adding a single group stage takes care of updating
ResultTypes accordingly.
Fixes: #38995.
Release note: None