build: compile RocksDB with -Wno-error-shadow #39121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Depends on cockroachdb/rocksdb#41 Cc @kenliu |
Clang 11.x (llvm 8.x) has new shadow warnings about enums which are being tickled by RocksDB. As a temporary workaround, don't error out on these warnings. Release note: None
petermattis
force-pushed
the
pmattis/rocksdb-no-error-shadow
branch
from
5477cb0
to
177dfe8
Compare
ajkr
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajkr)
|
TFTR! bors r=ajkr |
craig bot
pushed a commit
that referenced
this pull request
Jul 26, 2019
39121: build: compile RocksDB with -Wno-error-shadow r=ajkr a=petermattis Clang 11.x (llvm 8.x) has new shadow warnings about enums which are being tickled by RocksDB. As a temporary workaround, don't error out on these warnings. Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 11.x (llvm 8.x) has new shadow warnings about enums which are
being tickled by RocksDB. As a temporary workaround, don't error out on
these warnings.
Release note: None