Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl: Attempt at fixing flaky zone logic test. #39129

Closed
wants to merge 1 commit into from

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Jul 26, 2019

Addressing #38864

I couldn't get the errors to appear locally with make stress and stressrace.

Release note: None

@rohany rohany requested review from jordanlewis and a team July 26, 2019 20:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

Hmm... I don't feel particularly great about just retrying til it works. Why was it not working in the first place? Thanks for taking a look. How long did you run stress for? Try doing it for like 20 minutes on a gceworker.

@rohany
Copy link
Contributor Author

rohany commented Jul 29, 2019

I think it's some sort of race -- alot of the tests around it use the retry flag as well, so it seemed like this test was just missing it. I ran both for around 15 minutes on my laptop -- how do I set up a gce worker?

@jordanlewis
Copy link
Member

https://cockroachlabs.atlassian.net/wiki/spaces/ENG/pages/65077811/Building+with+gceworker

@danhhz
Copy link
Contributor

danhhz commented Jul 29, 2019

I also highly recommend roachprod-stress, which is like a bunch of parallel gceworkers, with none of the setup cost

roachprod create dan-stress -n 10 --gce-machine-type=n1-standard-8 --local-ssd=false
make roachprod-stress TESTS=Foo PKG=./pkg/foo CLUSTER=dan-stress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants