Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/zip: use "cockroach zip" as application name #39378

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 6, 2019

Fixes #39376.

.. this enables separate telemetry for the command.

Release note: None

@knz knz requested a review from tbg August 6, 2019 21:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

.. this enables separate telemetry for the command.

Release note: None
Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @tbg)

@knz
Copy link
Contributor Author

knz commented Aug 9, 2019

TFYR!

bors r+

craig bot pushed a commit that referenced this pull request Aug 9, 2019
39378: cli/zip: use "cockroach zip" as application name r=knz a=knz

Fixes #39376.

.. this enables separate telemetry for the command.

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Aug 9, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: cockroach zip uses app name "sql", not "zip"
3 participants