Revert "c-deps: fix assertion-enabled builds" #39562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 717c185. Apparently we violate the assertions. This needs to be fixed, but until then, let's keep the ball rolling. One likely culprit is cockroachdb#38932, see: cockroachdb#39034 (comment) Release note: None
|
This change is |
|
Interesting find. Curious to see next steps. LGTM |
|
TC passed the race build, so I assume it'll be green bors r=knz I expect the resolution to be driven by @jeffrey-xiao, @nvanbenschoten, and @ajkr. |
craig bot
pushed a commit
that referenced
this pull request
Aug 12, 2019
39562: Revert "c-deps: fix assertion-enabled builds" r=knz a=tbg This reverts commit 717c185. Apparently we violate the assertions. This needs to be fixed, but until then, let's keep the ball rolling. The assertion failures typically take the form > L0 file with seqno 90 90 vs. file with global_seqno 90 SIGABRT: abort See for example #39559 One likely culprit is #38932, see: #39034 (comment) Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
|
Filed #39564 to track the resolution. |
Build succeeded |
This was referenced Aug 28, 2019
This was referenced Aug 28, 2019
ajkr
added a commit
to ajkr/rocksdb
that referenced
this pull request
Sep 26, 2019
This is necessary to revert cockroachdb/cockroach#39562 to support RocksDB built without `-DNDEBUG`. Consecutive files ingested to L0 may be assigned the same seqnum, and this PR updates the LSM validation to allow that. There is a longer-term fix in facebook#5539. We should take that later, maybe after the 19.2 release. Test Plan: ran some tests that previously failed with corruption error like `ENABLE_ROCKSDB_ASSERTIONS=1 make PKG=github.com/cockroachdb/cockroach/pkg/ccl/backupccl testrace`; verified they succeed now.
ajkr
added a commit
to ajkr/rocksdb
that referenced
this pull request
Sep 27, 2019
This is necessary to revert cockroachdb/cockroach#39562 to support RocksDB built without `-DNDEBUG`. Consecutive files ingested to L0 may be assigned the same seqnum, and this PR updates the LSM validation to allow that. There is a longer-term fix in facebook#5539. We should take that later, maybe after the 19.2 release. Test Plan: ran some tests that previously failed with corruption error like `ENABLE_ROCKSDB_ASSERTIONS=1 make PKG=github.com/cockroachdb/cockroach/pkg/ccl/backupccl testrace`; verified they succeed now.
ajkr
added a commit
to cockroachdb/rocksdb
that referenced
this pull request
Sep 27, 2019
This is necessary to revert cockroachdb/cockroach#39562 to support RocksDB built without `-DNDEBUG`. Consecutive files ingested to L0 may be assigned the same seqnum, and this PR updates the LSM validation to allow that. There is a longer-term fix in facebook#5539. We should take that later, maybe after the 19.2 release. Test Plan: ran some tests that previously failed with corruption error like `ENABLE_ROCKSDB_ASSERTIONS=1 make PKG=github.com/cockroachdb/cockroach/pkg/ccl/backupccl testrace`; verified they succeed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 717c185.
Apparently we violate the assertions. This needs to be fixed, but until
then, let's keep the ball rolling.
The assertion failures typically take the form
See for example #39559
One likely culprit is #38932, see:
#39034 (comment)
Release note: None