sql: make FK schema changes backward-compatible with 19.1 #39614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
|
thoszhang
force-pushed
the
constraint-backward-compatibility
branch
from
63b54fa
to
8b493e4
Compare
thoszhang
force-pushed
the
constraint-backward-compatibility
branch
from
f0f7b27
to
8b493e4
Compare
thoszhang
force-pushed
the
constraint-backward-compatibility
branch
2 times, most recently
from
b0202e4
to
07e2ff0
Compare
dt
approved these changes
Aug 20, 2019
| COMMIT | ||
|
|
||
| # TODO(lucy): this fails (hangs) but we don't know why, in the mixed version state. | ||
| # TODO(lucy): This doesn't work and will become basically irrelevant when |
There was a problem hiding this comment.
it took me a little while to figure out what "this doesn't work" meant here, so might be good to explicitly call out "this hangs" or something instead.
This PR makes adding a foreign key using `ADD CONSTRAINT` backward-compatible with 19.1, by doing it in the user transaction and adding the constraint in the `Unvalidated` state if the cluster is not upgraded to 19.2, instead of queuing a mutation that can't be handled by 19.1 nodes. The cluster version used for this is `cluster.VersionTopLevelForeignKeys`, which is also used for the new foreign key representation. It made sense to reuse this cluster version since both sets of changes affect the same code, and it's assumed that either both or neither sets of changes will be active. This PR also updates the special mixed 19.1/19.2 logic tests for foreign keys, introduced in the FK representation refactoring, to revert the files to their 19.1 state, aside from some small changes to conform to unrelated 19.2 behavior, since 19.1 supports fewer FK schema change-related features. Release note: None
thoszhang
force-pushed
the
constraint-backward-compatibility
branch
from
07e2ff0
to
47a4c4f
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 20, 2019
39614: sql: make FK schema changes backward-compatible with 19.1 r=lucy-zhang a=lucy-zhang This PR makes adding a foreign key using `ADD CONSTRAINT` backward-compatible with 19.1, by doing it in the user transaction and adding the constraint in the `Unvalidated` state if the cluster is not upgraded to 19.2, instead of queuing a mutation that can't be handled by 19.1 nodes. The cluster version used for this is `cluster.VersionTopLevelForeignKeys`, which is also used for the new foreign key representation. It made sense to reuse this cluster version since both sets of changes affect the same code, and it's assumed that either both or neither sets of changes will be active. This PR also updates the special mixed 19.1/19.2 logic tests for foreign keys, introduced in the FK representation refactoring, to revert the files to their 19.1 state, aside from some small changes to conform to unrelated 19.2 behavior, since 19.1 supports fewer FK schema change-related features. Closes #39037. Release note: None Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adding a foreign key using
ADD CONSTRAINTbackward-compatiblewith 19.1, by doing it in the user transaction and adding the constraint in the
Unvalidatedstate if the cluster is not upgraded to 19.2, instead of queuinga mutation that can't be handled by 19.1 nodes.
The cluster version used for this is
cluster.VersionTopLevelForeignKeys,which is also used for the new foreign key representation. It made sense to
reuse this cluster version since both sets of changes affect the same code, and
it's assumed that either both or neither sets of changes will be active.
This PR also updates the special mixed 19.1/19.2 logic tests for foreign keys,
introduced in the FK representation refactoring, to revert the files to their
19.1 state, aside from some small changes to conform to unrelated 19.2
behavior, since 19.1 supports fewer FK schema change-related features.
Closes #39037.
Release note: None