config: propagate zone config info for non-gossiped system tables #39638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I'm happy to write an end-to-end test too if the reviewer would like it. I did verify manually that this change propagates MaxRangeBytes. |
ajwerner
force-pushed
the
ajwerner/fix-jobs-table-zone-configs
branch
from
31417e6
to
1584c0e
Compare
|
This still breaks some tests, let me fix them and I'll let you know when it's RFAL. |
ajwerner
force-pushed
the
ajwerner/fix-jobs-table-zone-configs
branch
2 times, most recently
from
52e1329
to
7a33e5e
Compare
ajwerner
commented
Aug 14, 2019
There was a problem hiding this comment.
Alright, figured it out. I needed to make sure to translate pseudo-table ids into the system database ID. RFAL.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Before this PR we would allow setting zone configurations on system tables but they would not propagate because the GetZoneConfig function would return the zone config for the entire system database. This leaves us in a still weird situation where some system tables will ignore their zone configs but not others. Fixes cockroachdb#39605. Release note (bug fix): Propagate zone configuration to non-gossiped system tables.
ajwerner
force-pushed
the
ajwerner/fix-jobs-table-zone-configs
branch
from
7a33e5e
to
ea56965
Compare
nvanbenschoten
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Aug 15, 2019
39638: config: propagate zone config info for non-gossiped system tables r=nvanbenschoten a=ajwerner Before this PR we would allow setting zone configurations on system tables but they would not propagate because the GetZoneConfig function would return the zone config for the entire system database. This leaves us in a still weird situation where some system tables will ignore their zone configs but not others. Fixes #39605. Release note (bug fix): Propagate zone configuration to non-gossiped system tables. Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Apr 23, 2020
The PublicSchemaID was introduced during the work for temp tables and the associated migration of the namespace table. The chosen constantly was erroneously put into the `PseudoTableIDs` which is used to create split points and control zone configs for low-level constructs like meta ranges, liveness range, timeseries, etc. This commit also fixed non-sense I introduced in cockroachdb#39638 while trying to enable real system tables to have their own zone configs (as opposed to just being controlled by the system zone config). All of the pseudo-table ids had corresponding filters below. This change should get backported as far back as 19.1. Release note (bug fix): Fix bug where an extra split was created in the keyspace which does not correspond to user data.
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jul 1, 2020
…o IDs The PublicSchemaID was introduced during the work for temp tables and the associated migration of the namespace table. The chosen constantly was erroneously put into the PseudoTableIDs which is used to create split points and control zone configs for low-level constructs like meta ranges, liveness range, timeseries, etc. This commit also fixed non-sense I introduced in cockroachdb#39638 while trying to enable real system tables to have their own zone configs (as opposed to just being controlled by the system zone config). All of the pseudo-table ids had corresponding filters below. This change should get backported as far back as 19.1. Release note (bug fix): Fix bug where an extra split was created in the keyspace which does not correspond to user data which could lead to a report of an under-replicated range in mixed-version 19.2-20.1 clusters.
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this pull request
Jul 2, 2020
The PublicSchemaID was introduced during the work for temp tables and the associated migration of the namespace table. The chosen constantly was erroneously put into the PseudoTableIDs which is used to create split points and control zone configs for low-level constructs like meta ranges, liveness range, timeseries, etc. This commit also fixed non-sense I introduced in cockroachdb#39638 while trying to enable real system tables to have their own zone configs (as opposed to just being controlled by the system zone config). All of the pseudo-table ids had corresponding filters below. This change should get backported as far back as 19.1. Release note (bug fix): Fix bug where an extra split was created in the keyspace which does not correspond to user data that could appear to be under-replicated in mixed-version clusters due to conflicting default zone configrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we would allow setting zone configurations on system tables but
they would not propagate because the GetZoneConfig function would return the
zone config for the entire system database. This leaves us in a still weird
situation where some system tables will ignore their zone configs but not
others.
Fixes #39605.
Release note (bug fix): Propagate zone configuration to non-gossiped system
tables.