sql: Add per replica locality information to show ranges.

[rohany]

Fixes #39793.

Release note (sql change): Show ranges now displays per replica
locality information.

[cockroach-teamcity]

This change is 

[rohany]

Bump

[solongordon]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rohany and @solongordon)

---

pkg/sql/crdb_internal.go, line 1855 at r1 (raw file):

  index_name           STRING NOT NULL,
	replicas             INT[] NOT NULL,	
  replica_localities   STRING[] NOT NULL,

Whitespace weirdness

---

pkg/sql/crdb_internal.go, line 1943 at r1 (raw file):

			}

			var voterReplicaLocalities []string

Nit: This slice seems unnecessary. You can just append to replicaLocalityArr as you iterate through voterReplicas.

---

pkg/sql/show_ranges_test.go, line 53 at r1 (raw file):

		expected := "{"
		for i, replica := range replicas {
			expected = expected + fmt.Sprintf("\"region=test,dc=dc%d\"", replica)

Nit: You can use += here. (In general strings.Builder is better but unnecessary in a unit test.)

Also, you can use the backtick to avoid escaping double quotes: `"region=test,dc=dc%d"`

[rohany]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @solongordon)

---

pkg/sql/crdb_internal.go, line 1855 at r1 (raw file):

Previously, solongordon (Solon) wrote…

Whitespace weirdness

what is the rule for this -- is it always supposed to be spaces?? I get this wrong on every PR i send.

---

pkg/sql/crdb_internal.go, line 1943 at r1 (raw file):

Previously, solongordon (Solon) wrote…

Nit: This slice seems unnecessary. You can just append to replicaLocalityArr as you iterate through voterReplicas.

Good catch.

---

pkg/sql/show_ranges_test.go, line 53 at r1 (raw file):

Previously, solongordon (Solon) wrote…

Nit: You can use += here. (In general strings.Builder is better but unnecessary in a unit test.)

Also, you can use the backtick to avoid escaping double quotes: `"region=test,dc=dc%d"`

Done

[rohany]

RFAL

[solongordon]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rohany and @solongordon)

---

pkg/sql/crdb_internal.go, line 1855 at r1 (raw file):

Previously, rohany (Rohan Yadav) wrote…

what is the rule for this -- is it always supposed to be spaces?? I get this wrong on every PR i send.

Yeah, I think spaces in strings, tabs for code. I always just match whatever the surrounding lines do. GoLand seems to get it right for me.

[rohany]

lol every error with spacing i have looks fine in goland :(

[rohany]

bors r=solongordon

[craig]

Build succeeded

• GitHub CI (Cockroach)