storage: fix stress flake #39838
Merged
storage: fix stress flake #39838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-stress-flake-for-TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic
branch
3 times, most recently
from
aab9feb
to
dab92c6
Compare
nvanbenschoten
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/storage/client_raft_test.go, line 4449 at r1 (raw file):
} } // Use SucceedsSoon for deal rare stress cases where the transfer may fail.
s/deal //
While stressing storage for cockroachdb#39643 I encountered TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic failing under stress. It also complained about the parent testing.T having been failed when then using a child so fixed that too though in a perhaps messy way. ``` --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic (2.29s) --- PASS: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/initial_run (0.14s) client_test.go:1280: [NotLeaseHolderError] r1: replica (n1,s1):1 not lease holder; current lease is repl=(n3,s3):3 seq=4 start=1566532897.322355813,1 exp=1566532898.378802707,0 pro=1566532897.478824123,0 --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart (1.02s) testing.go:820: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test ``` Release note: None
ajwerner
force-pushed
the
ajwerner/fix-stress-flake-for-TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic
branch
from
dab92c6
to
1eaa87d
Compare
ajwerner
commented
Sep 3, 2019
There was a problem hiding this comment.
TFTR
bors r+
Reviewable status:
pkg/storage/client_raft_test.go, line 4449 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
s/deal //
Done.
Build failed |
|
Flaked on #40361 bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 3, 2019
39832: changefeedccl: allow base64-encoded client certificate r=rolandcrosby a=rolandcrosby Adds `client_cert` and `client_key` options to the `kafka://` changefeed URI scheme. Works like the existing `ca_cert` option: the user base64-encodes the contents of a PEM certificate and private key, and passes those base64 values as parameters in the Kafka URI. Fixes #39817. Release note (enterprise change): Client certificates are now supported for Kafka changefeed authentication. 39838: storage: fix stress flake r=ajwerner a=ajwerner While stressing storage for #39643 I encountered TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic failing under stress. It also complained about the parent testing.T having been failed when then using a child so fixed that too though in a perhaps messy way. ``` --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic (2.29s) --- PASS: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/initial_run (0.14s) client_test.go:1280: [NotLeaseHolderError] r1: replica (n1,s1):1 not lease holder; current lease is repl=(n3,s3):3 seq=4 start=1566532897.322355813,1 exp=1566532898.378802707,0 pro=1566532897.478824123,0 --- FAIL: TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic/after_restart (1.02s) testing.go:820: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test ``` Release note: None Co-authored-by: Roland Crosby <roland@cockroachlabs.com> Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While stressing storage for #39643 I encountered
TestDefaultConnectionDisruptionDoesNotInterfereWithSystemTraffic
failing under stress. It also complained about the parent testing.T
having been failed when then using a child so fixed that too though
in a perhaps messy way.
Release note: None