pgwire: improve multiple portal error msgs #40197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
And relink to new issue. Release note: None
maddyblue
approved these changes
Aug 26, 2019
|
TFTR bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 26, 2019
39778: exec: support comparisons between all numeric types r=rafiss a=rafiss The vectorized engine now supports comparisons between floats, ints, and decimals. touches #39189 Release note: None 40197: pgwire: improve multiple portal error msgs r=jordanlewis a=jordanlewis And relink to new issue (#40195). Release note: None 40203: builtins: fix bug in aclexplode; add tests r=jordanlewis a=jordanlewis Closes #39794. Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
Apr 14, 2021
It looked like this was accidentally using WithSafeDetails, which is meant for sentry reporting. (Originally added in cockroachdb#40197.) Release note: None
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
Apr 20, 2021
It looked like this was accidentally using WithSafeDetails, which is meant for sentry reporting. (Originally added in cockroachdb#40197.) Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
63677: sql/pgwire: implicitly destroy portal on txn finish r=jordanlewis a=rafiss fixes #42912 touches #40195 This also includes a commit to fix an error message hint that seems to be accidentally using `WithSafeDetails`, which is meant for sentry reporting. (Originally added in #40197.) Release note (sql change): Previously, committing a transaction when a portal was suspended would cause a "multiple active portals not supported" error. Now, the portal is automatically destroyed. Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
craig bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
63677: sql/pgwire: implicitly destroy portal on txn finish r=jordanlewis a=rafiss fixes #42912 touches #40195 This also includes a commit to fix an error message hint that seems to be accidentally using `WithSafeDetails`, which is meant for sentry reporting. (Originally added in #40197.) Release note (sql change): Previously, committing a transaction when a portal was suspended would cause a "multiple active portals not supported" error. Now, the portal is automatically destroyed. 64252: opt: disallow fast path for cascading deletes with subqueries r=mgartner a=mgartner Previously, the optimizer would attempt to build a fast path cascading delete for `DELETE`s with a subquery. This caused errors when copying the original filters for the fast path query. The cascade query is built using a separate memo with metadata that does not include tables in the original memo's metadata. As a result, a Scan in a cascade fast path subquery could reference a table ID that did not exist in the metadata. This commit prevents building fast path cascading deletes if the delete has any subqueries. Fixes #64179 Release note (bug fix): Cascading `DELETE`s with subqueries no longer error. This bug was present since v21.1.0-alpha.1. 64277: logictest: temporarily disable vectorized flow assertion r=yuzefovich a=yuzefovich Informs: #64248. Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And relink to new issue (#40195).
Release note: None