jobs: make new index backfill status tracking bwd compatible #40288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Currently if a new node participates in a cluster with old version nodes the index backfill will be busy waiting since the different versions use different ways of reporting status. We detect this situation and revert to the old status reporting style if necessary. Touches cockroachdb#36601. Release note: None
spaskob
force-pushed
the
index-bwd-compatible
branch
from
6964e70
to
da74375
Compare
dt
approved these changes
Aug 29, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
40288: jobs: make new index backfill status tracking bwd compatible r=spaskob a=spaskob Currently if a new node participates in a cluster with old version nodes the index backfill will be busy waiting since the different versions use different ways of reporting status. We detect this situation and revert to the old status reporting style if necessary. Touches #36601. Release note: None Co-authored-by: Spas Bojanov <spas@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a new node participates in a cluster with old version nodes the index backfill
will be busy waiting since the different versions use different ways of reporting status.
We detect this situation and revert to the old status reporting style if necessary.
Touches #36601.
Release note: None