sql: add cluster setting for opt-driven FK checks, rename experimental_enable_zigzag_join #40307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
justinj
reviewed
Aug 28, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @rytaft)
RaduBerinde
force-pushed
the
fk-setting
branch
from
e3e0317
to
3a7f576
Compare
|
Made a few fixes: changed the name to end in |
Also renames the session setting to remove the `experimental_` part. Release note: None
Remove the "experimental" since it's enabled by default (and has been for a while). Release note: None
RaduBerinde
force-pushed
the
fk-setting
branch
from
3a7f576
to
00cb317
Compare
justinj
reviewed
Aug 29, 2019
There was a problem hiding this comment.
👍 still lgtm
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
40307: sql: add cluster setting for opt-driven FK checks, rename experimental_enable_zigzag_join r=RaduBerinde a=RaduBerinde #### sql: add cluster setting for opt-driven FK checks Also renames the session setting to remove the `experimental_` part. Release note: None #### sql: rename experimental_enable_zigzag_join Remove the "experimental" since it's enabled by default (and has been for a while). Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: add cluster setting for opt-driven FK checks
Also renames the session setting to remove the
experimental_part.Release note: None
sql: rename experimental_enable_zigzag_join
Remove the "experimental" since it's enabled by default (and has been
for a while).
Release note: None