-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: support \d client-side command with no arguments #40309
cli: support \d client-side command with no arguments #40309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, nice addition!
Reviewed 2 of 2 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained
No comment on the code but I'll paste this comment I made to Ken a while ago: the word "metacommand" is an anachronism and would be best replaced by "client-side command". Small bit of history: the word "metacommand" was introduced by pg in the 1980s-1990s at a time where there was a lot of activity in PL design. Back then there was a craze around "meta" constructs: bits of syntax in a language that would be expanded into other bits of syntax in the same language before the program would be further compiled/interpreted. Back then they were calling it "meta syntax" or "meta languages".
Hence the name "client-side command". Also the word "client-side" puts the emphasis on the fact this is specific to the CockroachDB SQL shell, and therefore users should not expect |
Thanks for the feedback everyone. @knz: that makes sense, thanks for the background! I was copying the verbiage used in the initial PR that added support for this, but I will adjust the wording in the code and commit message before merging. |
`\d` can be used with no arguments as a way to show all the tables in a database. This is an alias for `\dt`. Release note (cli change): Support `\d` client-side command with no arguments as an alias for `\dt`, for more ease of adoption by `psql` users.
f4e10a1
to
f5bc459
Compare
bors r+ |
40309: cli: support \d client-side command with no arguments r=rafiss a=rafiss `\d` can be used with no arguments as a way to show all the tables in a database. This is an alias for `\dt`. Release note (cli change): Support `\d` client-side command with no arguments as an alias for `\dt`, for more ease of adoption by `psql` users. Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Build succeeded |
\d
can be used with no arguments as a way to show all thetables in a database. This is an alias for
\dt
.Release note (cli change): Support
\d
client-side command with noarguments as an alias for
\dt
, for more ease of adoption bypsql
users.